Skip to content

Comments

chore: convert EmptyCardsDialogFragment to ViewBinding#19637

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-EmptyCardsDialogFragment
Nov 29, 2025
Merged

chore: convert EmptyCardsDialogFragment to ViewBinding#19637
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-EmptyCardsDialogFragment

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Pixel 9 API 35 Emulator
    • Screen opens and clicked 'Gallery'

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison marked this pull request as ready for review November 28, 2025 11:42
@david-allison david-allison mentioned this pull request Nov 28, 2025
92 tasks
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 28, 2025
@david-allison david-allison force-pushed the vb-EmptyCardsDialogFragment branch from dd6c029 to 49003c6 Compare November 29, 2025 00:09
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 29, 2025
@lukstbit lukstbit added this pull request to the merge queue Nov 29, 2025
Merged via the queue into ankidroid:main with commit 68c4b12 Nov 29, 2025
15 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 29, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants