Skip to content

chore: convert ReviewerMenuSettingsAdapter to ViewBinding & document class #19621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukstbit merged 2 commits into from
Nov 29, 2025
Merged

chore: convert ReviewerMenuSettingsAdapter to ViewBinding & document class #19621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ad1c4
chore: convert ReviewerMenuSettingsAdapter to ViewBinding
david-allison Sep 11, 2025
377a4d1
docs: ReviewerMenuSettingsAdapter
david-allison Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions AnkiDroid/src/main/java/com/ichi2/anki/preferences/reviewer/ReviewerMenuSettingsAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,25 @@ package com.ichi2.anki.preferences.reviewer

import android.view.LayoutInflater
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.widget.TextView
import androidx.appcompat.widget.AppCompatImageView
import androidx.recyclerview.widget.RecyclerView
import com.google.android.material.textview.MaterialTextView
import com.ichi2.anki.R
import com.ichi2.anki.utils.ext.findViewById
import com.ichi2.anki.databinding.ReviewerMenuDisplayTypeBinding
import com.ichi2.anki.databinding.ReviewerMenuItemBinding

/**
* Provides bindings from menu items and display types (headings) to [RecyclerView] views
* and support for dragging menu items to change display types or reorder.
*
* Handles ViewHolders for two classes:
* * [ReviewerMenuSettingsRecyclerItem.DisplayType] - Headings: Always show, Menu only, etc...
* * [DisplayTypeViewHolder]
* * [ReviewerMenuSettingsRecyclerItem.Action] - Study screen menu items: Undo, Flag, etc...
* * [ActionViewHolder]
*
* @see ReviewerMenuSettingsFragment
* @see ReviewerMenuSettingsRecyclerItem
*/
class ReviewerMenuSettingsAdapter(
private val items: List<ReviewerMenuSettingsRecyclerItem>,
) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {
Expand All @@ -36,12 +46,12 @@ class ReviewerMenuSettingsAdapter(
val inflater = LayoutInflater.from(parent.context)
return when (viewType) {
ReviewerMenuSettingsRecyclerItem.ACTION_VIEW_TYPE -> {
val itemView = inflater.inflate(R.layout.reviewer_menu_item, parent, false)
ActionViewHolder(itemView)
val binding = ReviewerMenuItemBinding.inflate(inflater, parent, false)
ActionViewHolder(binding)
}
ReviewerMenuSettingsRecyclerItem.DISPLAY_TYPE_VIEW_TYPE -> {
val itemView = inflater.inflate(R.layout.reviewer_menu_display_type, parent, false)
DisplayTypeViewHolder(itemView)
val binding = ReviewerMenuDisplayTypeBinding.inflate(inflater, parent, false)
DisplayTypeViewHolder(binding)
}
else -> throw IllegalArgumentException("Unexpected viewType")
}
Expand Down Expand Up @@ -70,13 +80,13 @@ class ReviewerMenuSettingsAdapter(

/** @see [R.layout.reviewer_menu_item] */
private inner class ActionViewHolder(
itemView: View,
) : RecyclerView.ViewHolder(itemView) {
private val binding: ReviewerMenuItemBinding,
) : RecyclerView.ViewHolder(binding.root) {
fun bind(action: ViewerAction) {
findViewById<TextView>(R.id.title).text = action.title(itemView.context)
action.drawableRes?.let { findViewById<AppCompatImageView>(R.id.icon).setBackgroundResource(it) }
binding.title.text = action.title(itemView.context)
action.drawableRes?.let { binding.icon.setBackgroundResource(it) }

findViewById<AppCompatImageView>(R.id.drag_handle).setOnTouchListener { _, event ->
binding.dragHandle.setOnTouchListener { _, event ->
if (event.action == MotionEvent.ACTION_DOWN) {
onDragHandleTouchedListener?.invoke(this)
}
Expand All @@ -87,10 +97,10 @@ class ReviewerMenuSettingsAdapter(

/** @see [R.layout.reviewer_menu_display_type] */
private class DisplayTypeViewHolder(
itemView: View,
) : RecyclerView.ViewHolder(itemView) {
private val binding: ReviewerMenuDisplayTypeBinding,
) : RecyclerView.ViewHolder(binding.root) {
fun bind(displayCategory: MenuDisplayType) {
findViewById<MaterialTextView>(R.id.title).setText(displayCategory.title)
binding.title.setText(displayCategory.title)
}
}
}
Expand Down