Skip to content

Comments

fix(deck-picker): prefer to use binding over checking 'fragmented' status#19601

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:19555-deck-picker-onResume
Nov 25, 2025
Merged

fix(deck-picker): prefer to use binding over checking 'fragmented' status#19601
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:19555-deck-picker-onResume

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Nov 24, 2025

Now we have moved to bindings, we can more easily detect whether the screen is fragmented

Fixes

Approach

  • use tryShowStudyOptionsPanel to detect if the view is fragmented
  • and a few logical improvements based on a view being nullable

How Has This Been Tested?

⚠️ API 34 tablet emulator - screen still works, unit tests still run

Learning (optional, can help others)

I strongly suspect this is another android:configChanges bug:

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Since we moved to view bindings, we can easily remove most
 references to 'fragmented' and use the state of the screen

Using `if (tryShowStudyOptionsPanel()) {` should resolve issue 19555
Added all reasons except for

Related: would help debugging issue 19555
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems reasonable

@mikehardy mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Nov 25, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 25, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 25, 2025
Merged via the queue into ankidroid:main with commit 5716fbf Nov 25, 2025
18 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 25, 2025
@github-actions github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Nov 25, 2025
@david-allison david-allison deleted the 19555-deck-picker-onResume branch November 25, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DeckPicker/Tablet: onResume Required value was null

3 participants