fix(deck-picker): prefer to use binding over checking 'fragmented' status#19601
Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom Nov 25, 2025
Merged
Conversation
Since we moved to view bindings, we can easily remove most
references to 'fragmented' and use the state of the screen
Using `if (tryShowStudyOptionsPanel()) {` should resolve issue 19555
Added all reasons except for Related: would help debugging issue 19555
5 tasks
BrayanDSO
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we have moved to bindings, we can more easily detect whether the screen is fragmented
Fixes
onResumeRequired value was null #19555Approach
tryShowStudyOptionsPanelto detect if the view is fragmentedHow Has This Been Tested?
Learning (optional, can help others)
I strongly suspect this is another
android:configChangesbug:Checklist