Skip to content

Comments

chore: convert ForgetCardsDialog to ViewBinding#19593

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-ForgetCardsDialog
Nov 25, 2025
Merged

chore: convert ForgetCardsDialog to ViewBinding#19593
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-ForgetCardsDialog

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Medium Tablet API 34 - fragment opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
You usually put the layout in the constructor.

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 24, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 24, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 24, 2025
Merged via the queue into ankidroid:main with commit 614e087 Nov 25, 2025
18 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 25, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants