Skip to content

Comments

chore: convert EditDeckDescriptionDialog to ViewBinding#19566

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-EditDeckDescriptionDialog
Nov 25, 2025
Merged

chore: convert EditDeckDescriptionDialog to ViewBinding#19566
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:vb-EditDeckDescriptionDialog

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Pixel 9 Pro Fold API 36 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The extension is less verbose and self-documenting code
Comment on lines 174 to 176
binding.deckDescriptionInput.setSelection(
binding.deckDescriptionInput.text!!.length,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was verbose, so I fixed it in a follow-up

@david-allison david-allison mentioned this pull request Nov 22, 2025
92 tasks
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable changes

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 23, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 25, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 25, 2025
Merged via the queue into ankidroid:main with commit 38dd423 Nov 25, 2025
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 25, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 25, 2025
@david-allison david-allison deleted the vb-EditDeckDescriptionDialog branch November 25, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants