Skip to content

Comments

chore: convert GradeNowDialog to ViewBinding#19565

Merged
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:vb-GradeNowDialog
Nov 23, 2025
Merged

chore: convert GradeNowDialog to ViewBinding#19565
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:vb-GradeNowDialog

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Pixel 9 Pro Fold API 36 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 23, 2025
@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 23, 2025
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Nov 23, 2025
@david-allison david-allison added this pull request to the merge queue Nov 23, 2025
Merged via the queue into ankidroid:main with commit cd7fe08 Nov 23, 2025
18 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 23, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 23, 2025
@david-allison david-allison deleted the vb-GradeNowDialog branch February 2, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants