Skip to content

Comments

chore: convert AxisPicker; AxisSelector; GestureDisplay to ViewBinding #19564

Merged
lukstbit merged 4 commits intoankidroid:mainfrom
david-allison:vb-gestures
Dec 2, 2025
Merged

chore: convert AxisPicker; AxisSelector; GestureDisplay to ViewBinding #19564
lukstbit merged 4 commits intoankidroid:mainfrom
david-allison:vb-gestures

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • My Google Pixel 9 Pro (Android 16) with an attached 8BitDo Ultimate 2C Wireless
    • Both Joystick screens still work
    • ⚠️ This is hard to test, as it requires physical components, we probably want a smoke test on this screen
  • Tested both 9 and 4-point touch gestures

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Nov 27, 2025
both "BRAKE" and "GAS" work here in my PS4 controller after this
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Nov 27, 2025
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 27, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't run this but the changes seem fine.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Dec 2, 2025
@lukstbit lukstbit added this pull request to the merge queue Dec 2, 2025
Merged via the queue into ankidroid:main with commit 98a5a5a Dec 2, 2025
15 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Dec 2, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants