Skip to content

Comments

chore: convert PermissionsItem to ViewBinding#19525

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-PermissionsItem
Nov 19, 2025
Merged

chore: convert PermissionsItem to ViewBinding#19525
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:vb-PermissionsItem

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • Pixel 9 Pro API 36 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Could not use vbpd due to an ID on a <Guideline>

Issue 11116
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Nov 19, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 19, 2025
Merged via the queue into ankidroid:main with commit 31562ab Nov 19, 2025
18 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 19, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 19, 2025
@david-allison david-allison deleted the vb-PermissionsItem branch November 19, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants