Skip to content

Comments

chore: convert CardAnalysisWidgetConfig to ViewBinding#19523

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-CardAnalysisWidgetConfig
Nov 19, 2025
Merged

chore: convert CardAnalysisWidgetConfig to ViewBinding#19523
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:vb-CardAnalysisWidgetConfig

Conversation

@david-allison
Copy link
Member

Approach

  • Manually converted this dialog due to changes since I performed the initial test conversion

How Has This Been Tested?

Brief test:

  • Pixel 9 Pro API 36 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison force-pushed the vb-CardAnalysisWidgetConfig branch from 6af861e to 72546e4 Compare November 18, 2025 19:25
@david-allison david-allison changed the title chore: convert DeckPickerWidgetConfig to ViewBinding chore: convert CardAnalysisWidgetConfig to ViewBinding Nov 18, 2025
@david-allison david-allison mentioned this pull request Nov 18, 2025
92 tasks
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored this myself so I'm fairly confident it works.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Nov 19, 2025
@lukstbit lukstbit added this pull request to the merge queue Nov 19, 2025
Merged via the queue into ankidroid:main with commit c0f9640 Nov 19, 2025
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 19, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 19, 2025
@david-allison david-allison deleted the vb-CardAnalysisWidgetConfig branch November 19, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants