Skip to content

Comments

chore: convert Info to ViewBinding #19471

Merged
BrayanDSO merged 3 commits intoankidroid:mainfrom
david-allison:info-vb
Nov 14, 2025
Merged

chore: convert Info to ViewBinding #19471
BrayanDSO merged 3 commits intoankidroid:mainfrom
david-allison:info-vb

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Nov 12, 2025

Approach

How Has This Been Tested?

Brief test:

  • Open Changelog

  • Pixel 6 Pro API 33 Emulator - screen opens

  • Pixel 34 Tablet emulator - screen opens

Learning

My Pixel 33 emulator didn't have the Play Store, therefore 'Rate AnkiDroid' didn't show

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I think we can go a bit further, see comment below.

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Nov 13, 2025
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Nov 14, 2025
@david-allison david-allison mentioned this pull request Nov 14, 2025
92 tasks
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 14, 2025
Merged via the queue into ankidroid:main with commit 49cc1ed Nov 14, 2025
15 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 14, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Nov 14, 2025
@david-allison david-allison deleted the info-vb branch November 14, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants