Skip to content

Comments

chore: convert CardBrowser to ViewBinding#19429

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:cardbrowser-vb
Nov 8, 2025
Merged

chore: convert CardBrowser to ViewBinding#19429
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:cardbrowser-vb

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test using

  • Pixel 6 Pro API 33 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

@criticalAY criticalAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 8, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

The layout property in CardBrowser on line 175 has become unused and should probably be removed.

Also with the changes from this PR, using the experimental new browser search view doesn't look too good:

Screenshot from 2025-11-08 14-38-30

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 8, 2025
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Nov 8, 2025
@david-allison
Copy link
Member Author

I'm OK with this

I had a lot of proposed work on the new layout before my break, nobody's going to be using the screen in the current state that it's in, and it's a line of code in DEV to get it working again

@david-allison david-allison mentioned this pull request Nov 8, 2025
92 tasks
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 8, 2025
Merged via the queue into ankidroid:main with commit 549977d Nov 8, 2025
15 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Nov 8, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 8, 2025
@david-allison david-allison deleted the cardbrowser-vb branch November 8, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants