Skip to content

Comments

Remove search from deck download menu#19382

Merged
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:enhancement/remove-search
Oct 30, 2025
Merged

Remove search from deck download menu#19382
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:enhancement/remove-search

Conversation

@criticalAY
Copy link
Contributor

Purpose / Description

  • There was a search option in menu which is not required IMO as there is already an option to search decks in webview and the search option in menu is redundant so this PR removes that

Fixes

NA but related to #19381

Approach

Remove search option from menu so that user now use the search option from web page itself

How Has This Been Tested?

Locally on API 35 Google emulator

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@criticalAY
Copy link
Contributor Author

Screenshot 2025-10-29 at 5 24 30 PM

The UI here will be different i.e. how it is in #19381 (once both PRs are merged)

@david-allison
Copy link
Member

david-allison commented Oct 29, 2025

No strong preference here.

The search bar allows for faster searching if a user has selected a deck/navigated away

But, it's badly designed and should collapse when submitted

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, I think having just the webiew page search is(slightly) better.

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Oct 30, 2025
@david-allison david-allison added this pull request to the merge queue Oct 30, 2025
Merged via the queue into ankidroid:main with commit eb13516 Oct 30, 2025
13 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Oct 30, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Oct 30, 2025
@github-actions
Copy link
Contributor

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@david-allison
Copy link
Member

Hi there @criticalAY! This is the OpenCollective Notice for PRs merged from 2025-10-01 through 2025-10-31

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants