Skip to content

Converted previewer empty front indicator to text#18208

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-empty-front-append-empty
Apr 6, 2025
Merged

Converted previewer empty front indicator to text#18208
lukstbit merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-empty-front-append-empty

Conversation

@ericli3690
Copy link
Member

Purpose / Description

Addresses @user1823's concerns at #18147 by implementing @BrayanDSO's suggestion. When a card's front is empty, the previewer tab now indicates this by appending (empty) to the tab title rather than using an overly-urgent looking red badge. Creates a new string resource and appends it in [TemplatePreviewerPage].

image

Fixes

Continues fixing #18107.

Approach

Adds a new string resource and appends it onto the tab title.

How Has This Been Tested?

Text displays properly on my end!

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Apr 5, 2025
When a card's front is empty, the previewer tab now indicates this by appending (empty) to the tab title rather than using an overly-urgent looking red badge.
Creates a new string resource and appends it in [TemplatePreviewerPage].
@ericli3690 ericli3690 force-pushed the ericli3690-empty-front-append-empty branch from 68af75a to e448881 Compare April 5, 2025 20:39
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Apr 5, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, thank you!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Apr 6, 2025
@lukstbit lukstbit added this pull request to the merge queue Apr 6, 2025
Merged via the queue into ankidroid:main with commit f535a08 Apr 6, 2025
9 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Apr 6, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Apr 6, 2025
@david-allison
Copy link
Member

Hi there @ericli3690! This is the OpenCollective Notice for PRs merged from 2025-04-01 through 2025-04-30

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants