Showing Badge for Blank Card Fronts in Previewer, Continued#18161
Closed
ericli3690 wants to merge 1 commit intoankidroid:mainfrom
Closed
Showing Badge for Blank Card Fronts in Previewer, Continued#18161ericli3690 wants to merge 1 commit intoankidroid:mainfrom
ericli3690 wants to merge 1 commit intoankidroid:mainfrom
Conversation
Added code in TemplatePreviewerViewModel to compute whether cards have empty fronts, and added warning badges to previewer tabs in TemplatePreviewerPage accordingly
Member
Author
|
Whoops, I found the button to reopen a PR. Please ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues PR #18147
Apologies for the inconvenience -- I accidentally closed the old PR while cleaning up my git history to be in line with the stated merge requirements. Having this in a new, separate PR is a bit annoying but I can't seem to reopen the old PR. I'll try not to let this happen again in the future.
This is rebased to main and is on a separate branch, eliminating the annoying "merge: ..." commit and putting everything into a single commit. I've implemented the suggestions from @BrayanDSO. The horizontal offset is now -4.
My tests show this code should work. Once it's merged, I'll create an issue on the upstream Anki repository to add a backend function so we can get rid of the string-matching hack in the future.
Please let me know if there are any other changes I should make and I'll be happy to correct them.