fix(empty-cards): make undoable, correct result, use backend strings#17745
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Jan 11, 2025
Merged
fix(empty-cards): make undoable, correct result, use backend strings#17745lukstbit merged 1 commit intoankidroid:mainfrom
lukstbit merged 1 commit intoankidroid:mainfrom
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
mikehardy
approved these changes
Jan 6, 2025
Member
mikehardy
left a comment
There was a problem hiding this comment.
last commit looks good to me, just bikeshedded you on a name.
approving because that naming is not that important to me vs moving right along here, do what you wish
AnkiDroid/src/main/java/com/ichi2/anki/deckpicker/DeckPickerViewModel.kt
Outdated
Show resolved
Hide resolved
lukstbit
reviewed
Jan 9, 2025
AnkiDroid/src/main/java/com/ichi2/anki/deckpicker/DeckPickerViewModel.kt
Outdated
Show resolved
Hide resolved
16ac926 to
9b676a8
Compare
Member
|
you're probably aware but unit tests failed, marked author reply |
* We use the backend string * We use `undoableOp` * we add 'undo' to the snackbar * We return the backend result, which may not be the supplied input - unit tested: duplicates empty_cards_deleted => TR.emptyCardsDeletedCount Fixes 16945 https://redirect.github.com/ankitects/anki/pull/3386
Member
Author
I wasn't. Fixed! |
4 tasks
Contributor
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes
Approach
opChanges { }opChangesWithCountTRrather thanstringsUndoto the snackbar, and only show it for a short durationHow Has This Been Tested?
Checklist