fix: Navigate Up versus Close#17623
Merged
mikehardy merged 1 commit intoankidroid:mainfrom Dec 22, 2024
Merged
Conversation
lukstbit
requested changes
Dec 18, 2024
Member
There was a problem hiding this comment.
This breaks the home icon in the toolbar.
The changes required for fixing the issue:
- replace the current (x) icon with the platform UP arrow icon (<-) so we match the platform UI
- on clicking that icon we should leave the screen completely
- don't break the home toolbar icon
25e4c14 to
7d001cf
Compare
mikehardy
requested changes
Dec 21, 2024
Member
mikehardy
left a comment
There was a problem hiding this comment.
request for comments explaining
7d001cf to
d3a6578
Compare
d3a6578 to
7385f70
Compare
mikehardy
approved these changes
Dec 22, 2024
Member
mikehardy
left a comment
There was a problem hiding this comment.
Thanks for adding the comment - didn't mean to be picky it was just subtle and I thought a comment addition would be really easy + help in the future. I appreciate it anyway
Cheers
Member
|
Thought this was pickable for a 2.20.1 release and gave it a shot but it relies on other changes already being in place from #17579 and those don't pick cleanly at all, so no cherry-pick for this one |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
How Has This Been Tested?
Physical Device
Checklist