Skip to content

Comments

fix: Navigate Up versus Close#17623

Merged
mikehardy merged 1 commit intoankidroid:mainfrom
Prince-kushwaha:issue-17609
Dec 22, 2024
Merged

fix: Navigate Up versus Close#17623
mikehardy merged 1 commit intoankidroid:mainfrom
Prince-kushwaha:issue-17609

Conversation

@Prince-kushwaha
Copy link
Contributor

@Prince-kushwaha Prince-kushwaha commented Dec 18, 2024

Fixes

How Has This Been Tested?

Physical Device

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the home icon in the toolbar.
The changes required for fixing the issue:

  • replace the current (x) icon with the platform UP arrow icon (<-) so we match the platform UI
  • on clicking that icon we should leave the screen completely
  • don't break the home toolbar icon

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Dec 18, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Dec 21, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request for comments explaining

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment - didn't mean to be picky it was just subtle and I thought a comment addition would be really easy + help in the future. I appreciate it anyway

Cheers

@mikehardy mikehardy added this pull request to the merge queue Dec 22, 2024
Merged via the queue into ankidroid:main with commit fb02c90 Dec 22, 2024
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Dec 22, 2024
@github-actions github-actions bot added this to the 2.21 release milestone Dec 22, 2024
@mikehardy
Copy link
Member

Thought this was pickable for a 2.20.1 release and gave it a shot but it relies on other changes already being in place from #17579 and those don't pick cleanly at all, so no cherry-pick for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Navigate Up versus Close

4 participants