style(lint) manual fixes for gradle.ktlint 12.1.1 / ktLint 1.5.0#17577
Merged
mikehardy merged 1 commit intoankidroid:mainfrom Dec 9, 2024
Merged
style(lint) manual fixes for gradle.ktlint 12.1.1 / ktLint 1.5.0#17577mikehardy merged 1 commit intoankidroid:mainfrom
mikehardy merged 1 commit intoankidroid:mainfrom
Conversation
e993596 to
3f3a664
Compare
**This is incomplete** This prepares for the gradle plugin upgrade And some for ktlint 1.5.0 `./gradlew ktLintCheck` passes after this commit Process: * run `./gradlew AnkiDroid:ktlintFormat` * find the file and line number * rollback the changes (line numbers no longer match) * fix the error * amend to this commit disabling git hooks Some issues: * Exceeded max line length (140) (cannot be auto-corrected) * a block comment may not be preceded by a block comment (cannot be auto-corrected) * a block comment may not be preceded by an EOL comment unless separated by a blank line (cannot be auto-corrected) * an EOL comment may not be preceded by a block comment unless separated by a blank line (cannot be auto-corrected) * an EOL comment may not be preceded by a KDoc. Reversed order is allowed though when separated by a newline. (cannot be auto-corrected) * A comment inside or on same line after a 'value_parameter' is not allowed. It may be placed on a separate line above. (cannot be auto-corrected) * A block comment in between other elements on the same line is disallowed (cannot be auto-corrected) Co-authored-by: David Allison <62114487+david-allison-1@users.noreply.github.com>
3f3a664 to
751a84b
Compare
mikehardy
approved these changes
Dec 9, 2024
Member
mikehardy
left a comment
There was a problem hiding this comment.
thanks for taking this on, been hanging out forever!
This was referenced Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is incomplete, but please merge to reduce conflicts
Pending:
This prepares for the gradle plugin upgrade
And some for ktLint 1.5.0
Process:
./gradlew AnkiDroid:ktlintFormatSome issues:
Checklist