Skip to content

refactor: Custom Study #17576

Merged
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:custom_study_refactor
Dec 10, 2024
Merged

refactor: Custom Study #17576
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:custom_study_refactor

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Dec 9, 2024

How Has This Been Tested?

Untested

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Review cleanup Non functional change that would improve the code readability squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. labels Dec 9, 2024
mikehardy
mikehardy approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seem fine to me

@mikehardy mikehardy added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 9, 2024
lukstbit
lukstbit approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Dec 9, 2024
@david-allison david-allison added the Blocked by dependency Currently blocked by some other dependent / related change label Dec 9, 2024
@david-allison
Copy link
Member Author

david-allison commented Dec 9, 2024

@david-allison david-allison removed the squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. label Dec 9, 2024
@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Blocked by dependency Currently blocked by some other dependent / related change labels Dec 10, 2024
@david-allison
refactor(custom-study): arguments & add docs
d7c9461 
* move arg keys to companion object

* renames:
`DID` => `ARG_DID`
`ID` => `ARG_SUB_DIALOG_ID`, `"id"` => `"subDialogId"`

I don't feel these are important variables to have at the start
of the file

----

refactor(custom-study): make `selectedSubDialog` a property

previously: `getOption()`

----

refactor: introduce `dialogDeckId`

----

docs: CustomStudyDialog
@david-allison david-allison removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Dec 10, 2024
@david-allison david-allison added this pull request to the merge queue Dec 10, 2024
Merged via the queue into ankidroid:main with commit c53c242 Dec 10, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 10, 2024
@github-actions github-actions bot added this to the 2.21 release milestone Dec 10, 2024
@david-allison david-allison deleted the custom_study_refactor branch December 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

@lukstbit lukstbit lukstbit approved these changes

Assignees

No one assigned

Labels

cleanup Non functional change that would improve the code readability

Projects

None yet

Milestone

2.21 release

Development

Successfully merging this pull request may close these issues.

3 participants

@david-allison @mikehardy @lukstbit