Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: FlashardViewer - remove 'controlBlocked' #15032

Merged
merged 5 commits into from
Dec 21, 2023
Merged

cleanup: FlashardViewer - remove 'controlBlocked' #15032

merged 5 commits into from
Dec 21, 2023

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Dec 19, 2023 •
edited
Loading

No longer used in the new backend + suspend functions.

No calls were made to blockControls, and everything else passed through this

I suspect unrelated to #14708

But it'll provide a small speedup anyway

How Has This Been Tested?

Flipped a card on an API 33 emulator, and trusting CI

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Review cleanup Non functional change that would improve the code readability squash-merge The pull request currently requires maintainers to "Squash Merge" labels Dec 19, 2023
mikehardy
mikehardy approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine - going with it as I know you'll follow up if needed...

@mikehardy mikehardy merged commit 2ea63bf into ankidroid:main Dec 21, 2023
8 checks passed
@github-actions github-actions bot added this to the 2.17 release milestone Dec 21, 2023
@github-actions github-actions bot removed Needs Review squash-merge The pull request currently requires maintainers to "Squash Merge" labels Dec 21, 2023
@david-allison david-allison deleted the remove-slow-ui branch December 25, 2023 03:40
bkzhn pushed a commit to bkzhn/Anki-Android that referenced this pull request Jan 14, 2024
@david-allison @bkzhn
cleanup: FlashardViewer - remove 'controlBlocked' (ankidroid#15032)
2ec10cb 
* chore: remove 'blockControls' (unused)
* chore: remove 'controlBlocked' (unused)
* chore: remove 'isControlBlocked' (unused)
* chore: remove 'reviewerUI' param (unused)
* chore: remove 'slow UI' references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
cleanup Non functional change that would improve the code readability
Projects
None yet
Milestone
2.17 release
Development

Successfully merging this pull request may close these issues.
2 participants
@david-allison @mikehardy