Previewer: kotlin.UninitializedPropertyAccessException: lateinit property config has not been initialized

[david-allison]

https://github.com/ankidroid/Anki-Android/actions/runs/20076406192/job/57591859986

PreviewerViewModelTest > next, slider and previous navigation integration FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at com.ichi2.anki.previewer.PreviewerViewModelTest$next, slider and previous navigation integration$1.invokeSuspend(PreviewerViewModelTest.kt:203)
        at com.ichi2.anki.previewer.PreviewerViewModelTest$next, slider and previous navigation integration$1.invoke(PreviewerViewModelTest.kt)
        at com.ichi2.anki.previewer.PreviewerViewModelTest$next, slider and previous navigation integration$1.invoke(PreviewerViewModelTest.kt)
        at com.ichi2.anki.libanki.testutils.AnkiTest.runTestInner$suspendImpl(AnkiTest.kt:336)
        at com.ichi2.anki.libanki.testutils.AnkiTest.runTestInner(AnkiTest.kt)
        at com.ichi2.anki.libanki.testutils.InMemoryAnkiTest.runTestInner(InMemoryAnkiTest.kt:36)
        at com.ichi2.anki.libanki.testutils.AnkiTest$runTest$1$1.invokeSuspend(AnkiTest.kt:329)
        at com.ichi2.anki.libanki.testutils.AnkiTest$runTest$1$1.invoke(AnkiTest.kt)
        at com.ichi2.anki.libanki.testutils.AnkiTest$runTest$1$1.invoke(AnkiTest.kt)
        at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$2$1$1.invokeSuspend(TestBuilders.kt:317)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
        at kotlinx.coroutines.test.TestDispatcher.processEvent$kotlinx_coroutines_test(TestDispatcher.kt:24)
        at kotlinx.coroutines.test.TestCoroutineScheduler.tryRunNextTaskUnless$kotlinx_coroutines_test(TestCoroutineScheduler.kt:99)
        at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$2$1$workRunner$1.invokeSuspend(TestBuilders.kt:326)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:94)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:70)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:48)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:10)
        at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest-8Mi8wO0(TestBuilders.kt:309)
        at kotlinx.coroutines.test.TestBuildersKt.runTest-8Mi8wO0(Unknown Source)
        at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest-8Mi8wO0(TestBuilders.kt:167)
        at kotlinx.coroutines.test.TestBuildersKt.runTest-8Mi8wO0(Unknown Source)
        at com.ichi2.anki.libanki.testutils.AnkiTest.runTest(AnkiTest.kt:328)
        at com.ichi2.anki.libanki.testutils.InMemoryAnkiTest.runTest(InMemoryAnkiTest.kt:36)
        at com.ichi2.anki.libanki.testutils.AnkiTest.runTest$default(AnkiTest.kt:317)
        at com.ichi2.anki.previewer.PreviewerViewModelTest.next, slider and previous navigation integration(PreviewerViewModelTest.kt:178)

[david-allison]

ca6581f

• test: previewer #19647

@BrayanDSO FYI

[BrayanDSO]

I guess that the flake is around the advanceUntilIdle() usages. Maybe the code on PreviewerFragment could be refactored so the coroutines are more predictable. I'll check it out later among other stuff to refactor

[david-allison]

Sounds good, I'll ignore it for now to keep CI flowing

[david-allison]

@BrayanDSO This is a bug

We do not wait for the coroutines in onPageFinished to complete before taking further actions => CardMediaPlayer:loadCardAvTags may not have completed before a user action occurs => CardMediaPlayer.config would be uninitialized.

Index: AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerViewModel.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerViewModel.kt b/AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerViewModel.kt
--- a/AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerViewModel.kt	(revision fde9bd4e86c638a234be312026e22e6c7715b1e1)
+++ b/AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerViewModel.kt	(date 1767578596479)
@@ -39,6 +39,7 @@
 import com.ichi2.anki.utils.ext.require
 import com.ichi2.anki.utils.ext.setUserFlagForCards
 import kotlinx.coroutines.Deferred
+import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.flow.combine
@@ -237,6 +238,7 @@
                 showingAnswer.value -> CardSide.ANSWER
                 else -> CardSide.QUESTION
             }
+        delay(10_000)
         cardMediaPlayer.loadCardAvTags(currentCard.await())
         cardMediaPlayer.autoplayAllForSide(side)
     }

• Add a card with TTS
• Browser - Preview
• Flip a card