Skip to content

Image Occlusion: cannot edit deck of a card #19605

@david-allison

Description

@david-allison

We edit using UpdateImageOcclusionNote, which does not include a deck ID

https://github.com/ankitects/anki/blob/5614d20bedcc4dd268136d389ad796b404a69d2c/proto/anki/image_occlusion.proto#L88-L94

Although the deck spinner is visible on the screen, we do nothing with it other than set the current deck.


We have some use cases:

  • A user wants to edit a card when studying
  • A user wants to edit a selection of cards from the same note [Card Browser - CARDS]
  • A user wants to edit a note [Card Browser - NOTES]
    • ❓ What does it mean to edit the deck of a note, is a user aware of this?
    • Do we care, given the user can use 'change deck'?
    • => Do what we did before the deck selection was moved to the IO screen

Note: A user can remove the cards they are editing (by removing masks).

Each of these use cases needs to handle this eventuality

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions