Remove `DeckSpinnerSelection` and recode `DeckSelectionDialog`

[david-allison]

It's been a mess for years. We can do much better, especially now we're in Kotlin

This class originally existed because we had a spinner to select decks

This became DeckSelectionDialog, but the spinner remained.

This could be a spinner embedded in the App Bar, or a View in Note Editor.

Even if we keep a spinner control for the UI, the implementation is currently far too complex to justify it.

CreateDeckDialog was then added into DeckSelectionDialog, so in some instances, the calling activity needs to handle a newly created deck from this dialog.

[ericli3690]

Some thoughts on this task from #19303, which is a limited fix dealing with an existing bug in the currently messy implementation. I might take on the full rewrite of these classes in a few months if I have some free time, but unfortunately I can't make any promises.

Both fromCollection and decks.allNamesAndIds are used to retrieve the deck names from the collection, which is confusing. We should figure out a single unified method for checking if a deck should be displayed in the DeckSelectionDialog. If we want to use SelectableDeck.fromCollection for doing so, then this should be properly documented and all direct uses of decks.allNamesAndIds should be removed. Further, why is DeckSelectionDialog providing logic for filtering the list of decks it's provided even further (see this line in DeckSelectionDialog)? Either we should move all the logic for figuring out what decks to display to DeckSelectionDialog, or DeckSelectionDialog should be simplified so it immediately shows the decks it's provided without applying any further filtering logic. In short: the code for deciding which decks to display should be centralized. Once the classes are cleaned up, testing will need to be done to ensure this issue is solved in all possible use cases for DeckSpinnerSelection (Statistics, CardBrowser, etc.).

[lukstbit]

I implemented all the code to replace DeckSpinnerSelection with a TextView. I also created a new CreateDeckDialogFragment to replace the current class CreateDeckDialog.

Once the code for these is merged I can implement a new DeckSelectionDialog.