Fix target loss in shadow DOM by storing the target element #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of the concerns raised in #314 .
This pull request includes changes to the
InfiniteScrollcomponent insrc/index.tsxto fix an issue with target loss in the shadow DOM. The most important changes include adding a private_targetproperty to store the target element and modifying the logic to use this stored target element if necessary.Improvements to target handling in shadow DOM:
src/index.tsx: Added a private_targetproperty to store the target element.src/index.tsx: Modified the logic to use the stored_targetelement if the event target is not available, and ensured the_targetis updated with the current target element.