Fixed normalize for nil values

ankane · Oct 7, 2024 · 275677b · 275677b
1 parent 02788d3
commit 275677b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/neighbor/utils.rb b/lib/neighbor/utils.rb
@@ -31,6 +31,8 @@ def self.validate(value, dimensions:, type:, adapter:)
     end
 
     def self.normalize(value, column_info:)
+      return nil if value.nil?
+
       raise Error, "Normalize not supported for type" unless [:cube, :vector, :halfvec, :binary].include?(column_info&.type)
 
       norm = Math.sqrt(value.sum { |v| v * v })

diff --git a/test/cube_test.rb b/test/cube_test.rb
@@ -102,9 +102,15 @@ def test_normalize
     item = CosineItem.new
     item.cube_embedding = [0, 3, 4]
     assert_elements_in_delta [0, 0.6, 0.8], item.cube_embedding
+
     item.save!
     assert_elements_in_delta [0, 0.6, 0.8], item.cube_embedding
     assert_elements_in_delta [0, 0.6, 0.8], Item.last.cube_embedding
+
+    item.cube_embedding = nil
+    item.save!
+    assert_nil item.cube_embedding
+    assert_nil Item.last.cube_embedding
   end
 
   def test_insert