skip_action is undefined

[koenpunt]

Do not merge

skip_action never existed, the preferred method now is calling all the skip methods individually.

What is the purpose of skipping all callbacks?

[ankane]

Hey @koenpunt, thanks for reporting. It looks like skip_action_callback is the correct name.
http://apidock.com/rails/v4.2.1/AbstractController/Callbacks/ClassMethods/skip_filter

The purpose is to prevent any ApplicationController callbacks from interfering with Ahoy, while still allowing the user to use methods like current_user that are defined in ApplicationController.

[ankane]

Nevermind, looks like that's deprecated as well :(

[koenpunt]

The purpose is to prevent any ApplicationController callbacks from interfering with Ahoy, while still allowing the user to use methods like current_user that are defined in ApplicationController.

Wouldn't is be easier to extend from ActionController::Base then? And forward helper calls or something. Or just add a current_user method?

[ankane]

This is how Ahoy originally was built (changed to ApplicationController at 0.1.3).

I'm not sure how you could forward calls to ApplicationController from ActionController::Base, but open to a PR if you can figure out a solution. While extending ApplicationController adds a bit of complexity for Ahoy, I don't see the harm in the current approach.