Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop #14

Merged
merged 1 commit into from
Jan 31, 2024
Merged

drop #14

merged 1 commit into from
Jan 31, 2024

Conversation

feng-intel
Copy link
Contributor

Thanks for your review.

@ankan-ban
Copy link
Owner

Nice job @feng-intel!
I didn't know sycl is so similar to CUDA.
I see that you have copied the cuda implementation into a new folder and modified it. Given that the implementation doesn't share any code, is there any advantage of having it part of this repo (vs having it in a separate repo)?

@feng-intel
Copy link
Contributor Author

The advantage is user can compare the cuda code with sycl code I think. Thanks.

@feng-intel
Copy link
Contributor Author

Hi Ankan, any update?

@ankan-ban
Copy link
Owner

If you think it's useful to have in same repo, I don't have any concerns. Agree that some people may find it useful. Merging.

@ankan-ban ankan-ban merged commit 877340f into ankan-ban:main Jan 31, 2024
@feng-intel feng-intel changed the title Support Intel dGPU/iGPU platforms. Support Intel dGPU/iGPU platforms Mar 15, 2024
@feng-intel feng-intel changed the title Support Intel dGPU/iGPU platforms drop Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feng-intel @ankan-ban