Converted single-element arraylist into singleton list. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have modest memory benefits.
serggl
requested changes
Jun 1, 2017
| import java.util.Date; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
| import java.util.*; |
There was a problem hiding this comment.
can we have it back to an explicit list of imports?
There was a problem hiding this comment.
I should send you a gif of me trying to do that, but my IDE keeps reverting to import java.util.*;. It's actually pretty funny.
I'll just change IDE settings and amend this PR. :)
serggl
approved these changes
Jun 2, 2017
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
* Converted single-element arraylist into singleton list. Should have modest memory benefits. * Updated PR per review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have modest memory benefits.