-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 251. Pulled bindPlayServices() out of constructor and into separate initialize() method #252
Issue 251. Pulled bindPlayServices() out of constructor and into separate initialize() method #252
Conversation
@autonomousapps this should be done as an alternative constructor option I guess |
Ah, that's a good idea. How do you feel about static factory constructors? Or would you prefer another constructor with, say, a boolean parameter? |
I've updated my PR to add overloaded constructors and factory methods so that this change will be non-breaking to current library users. |
@autonomousapps this now looks good. Can you please update README with new factory method description/instructions ? |
Absolutely. I'll have it updated today. I see the build failed with:
I haven't used TravisCI, so I'm not sure how to see the style failures. Could you tell me if they're my new code and how I can address them? |
0a06768
to
dbd9399
Compare
Updated PR and squashed into one commit. |
@autonomousapps sorry my fault. I should probably update readme with a checkstyle requirements. Basically you need to ensure that And ready to merge this PR once you will pass checkstyle. Thank you! |
…of play services. New initialize() method calls bindPlayServices(). Updated README.md.
dbd9399
to
d68d66e
Compare
I've amended my commit and force-pushed. Fixes all checkstyle issues. |
…of play services. (anjlab#252) New initialize() method calls bindPlayServices(). Updated README.md.
Code is self-explanatory, but breaking for current users.
Rationale:
Sometimes,
bindPlayServices()
finishes its asynchronous work before the constructor finishes. This can mean thatonBillingInitialized()
is called before the constructor finishes, and so work involving abillingProcessor
can result in NPEs.