Feature/add additional checker #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serggl
added a commit
that referenced
this pull request
Dec 24, 2016
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
* one time prodcut checker method * Update README.md
showdpro
pushed a commit
to showdpro/android-inapp-billing-v3
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi AnjLab, here is the brief explanation why I made those changes.
After having a meeting with google guys I found out that checking for "lab service" as you do here is not enough. We have an use case when we have to check first whether the lab is supported or not. Depending on that our payment page will show Iab as a payment option if it's supported.
Example:
If the phone does not have sim card your method will return true since it's just checking for the existence of the package name but eventually lab service won't work because there is no sim card installed.
I know that it's really rear case but we still want to cover it since we have more than 1 million active users worldwide.
Lastly, I am proposing to have this extra method to make it more reliable no matter what are the circumstances are. If I need one-time purchase I will check for that, if I need subscription I will check for that. Please give a comment if you have any concern. By the way, great library, keep it up!