-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Issue60 view other member details #62
Feat: Issue60 view other member details #62
Conversation
@meenakshi-dhanani . I'm having trouble trying to get the Member Profile page to render the member details. The problem could be because of the page is under Protected page under another Protected page (Members). I've pushed the code I have so far. Can you please give me a hint how to troubleshoot this? Thanks |
ad73f73
to
fc841bb
Compare
Update @meenakshi-dhanani and @anitab-org/bridgeintech-maintainers. I've pushed the lateest changes. This PR is now ready to be reviewed. Please check it out when you have time. Thanks |
@ramitsawhney27 . In this View other member details UI, I do not use GET /users/{user_id} endpoint to get the member details. In fact, I directly pick user using the mapping on list of users returned from the GET /users requests from the |
fc841bb
to
1aba46e
Compare
LGTM! Just would want to rename the component to Member |
fix handlelick fix redirecting to member detail Fix field type to non input Remove console.log
1aba46e
to
3941645
Compare
Update @meenakshi-dhanani and @anitab-org/bridgeintech-maintainers. I've resolved the conflict. Can you please re-review this PR? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made in this PR were tested locally. Following are the results:
Description
Allow user to view other member's personal details
Fixes #60
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Members
and select a member from the list of usersChecklist:
Code/Quality Assurance Only