Skip to content

Conversation

09xHarsh
Copy link
Contributor

  • Solved leetcode's problem no. 9 (Palindrome Number) in JavaScript.

@anishLearnsToCode
Copy link
Owner

Please add link to problem and time and space complexity as well:

// https://leetcode.com/problems/palindrome-number
// T: O(log(n))
// S: O(1)

- Added link to the problem
- Added T.C. as well as S.C.
@anishLearnsToCode
Copy link
Owner

Another thing, every file should end with a new line character \n, so please add that as well. Thanks for taking all this feedback :) and i will merge it after that.

@09xHarsh
Copy link
Contributor Author

Can you give an example for better understanding.

@anishLearnsToCode
Copy link
Owner

ofcourse !! so basically every file in programming should end with a new line, basically there should be one extra line in every file irrespective of the extenstion. so if it is .py .java or .js whatever the end should be like:

class Hello {
}
\n --> this is extra line
class Hello:
  def __init__():
    print('stuff')
\n -> extra line here
const hello = () => {
  console.log('hello');
};
\n --> extra line

@anishLearnsToCode anishLearnsToCode merged commit b9e85e6 into anishLearnsToCode:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants