feat: Added a wrapper for the react-router-dom navigate hook #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Lanser <tom@animo.id>
Signed-off-by: Tom Lanser <tom@animo.id>
berendsliedrecht
approved these changes
Nov 30, 2022
| @@ -9,6 +9,8 @@ import { AgentHomeScreen } from './pages/agent/AgentHomeScreen' | |||
| import { ConnectionsScreen } from './pages/agent/connections/ConnectionsScreen' | |||
| import { CredentialsScreen } from './pages/agent/credentials/CredentialsScreen' | |||
|
|
|||
| export const routeUrls = ['/', '/setup', '/agent', '/agent/connections', '/agent/credentials', '/agent/proofs'] as const | |||
There was a problem hiding this comment.
Ideally we would want to infer this from the routes object below. Can you create an issue for this?
|
|
||
| type Routes = typeof routeUrls | ||
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| type ExtractValues<T extends string, U extends object = {}> = T extends `${string}{${infer V}}${infer Rest}` |
There was a problem hiding this comment.
Can you also create an issue to fix this? I might be able to look at it someday, but if this works for now that is fine.
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Lanser tom@animo.id