feat: Decline problem report #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Lanser <tom@devv.nl>
Signed-off-by: Tom Lanser <tom@devv.nl>
TimoGlastra
approved these changes
Apr 12, 2024
Comment on lines
+161
to
+174
| mutationKey: ['declineDidCommPresentation', proofExchangeId], | ||
| mutationFn: async () => { | ||
| const presentationDeclined$ = agent.events | ||
| .observable<ProofStateChangedEvent>(ProofEventTypes.ProofStateChanged) | ||
| .pipe( | ||
| // Correct record with id and state | ||
| filter( | ||
| (event) => | ||
| event.payload.proofRecord.id === proofExchangeId && | ||
| [ProofState.Declined].includes(event.payload.proofRecord.state) | ||
| ), | ||
| // 10 seconds to complete exchange | ||
| timeout(10000), | ||
| first() |
There was a problem hiding this comment.
I think the method call will wait with returning until this state is reached, so i think we can remove it
There was a problem hiding this comment.
But it's quite nice to have this functionality right just like the accept action. And the state is updated locally in afj right for the record or does it have to wait for the external party?
Yes, added the credential decline now 😄 |
Signed-off-by: Tom Lanser <tom@devv.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the decline problem report in the Paradym wallet.