Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QR scanner package #1

Merged
merged 9 commits into from
May 23, 2023
Merged

feat: QR scanner package #1

merged 9 commits into from
May 23, 2023

Conversation

janrtvld
Copy link
Contributor

@janrtvld janrtvld commented May 15, 2023

Note: Draft PR as i'm still working on the parsing for the QR scanner.

This PR contains some general Tamagui setup and a QR scanner. The Tamagui components will probably still change in the future, but for now i created some base components. The export * from 'tamagui' has been removed and you should now only use predefined components from the '@internal/ui' package.

Current flow:

RPReplay_Final1684177142.MP4

Signed-off-by: Jan <jan@animo.id>
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re the toasts, they're a bit hard to see on the white background, should we add some depth? I also see there's multiple ways to do toasts in the template. One using tamgui, the other using burnt (https://www.npmjs.com/package/burnt). Should we remove the burnt package? Or do we want to use some of it's features?

apps/expo/app/_layout.tsx Outdated Show resolved Hide resolved
packages/app/features/scan/screen.tsx Outdated Show resolved Hide resolved
packages/app/features/scan/screen.tsx Outdated Show resolved Hide resolved
packages/app/provider/index.tsx Outdated Show resolved Hide resolved
packages/scanner/package.json Outdated Show resolved Hide resolved
packages/scanner/package.json Outdated Show resolved Hide resolved
packages/scanner/package.json Outdated Show resolved Hide resolved
packages/scanner/src/Scanner.tsx Show resolved Hide resolved
packages/ui/src/panels/CustomToast.tsx Outdated Show resolved Hide resolved
packages/agent/src/offerParsers.ts Outdated Show resolved Hide resolved
Co-authored-by: Timo Glastra <timo@animo.id>
@janrtvld
Copy link
Contributor Author

I dont think we can remove burnt. It says that Toast relies on the burnt package https://tamagui.dev/docs/components/toast/1.15.15#toastprovider.

Signed-off-by: Jan <jan@animo.id>
@janrtvld janrtvld marked this pull request as ready for review May 22, 2023 14:47
@janrtvld janrtvld changed the title feat: added qr scanner feat: added qr scanner package May 22, 2023
@janrtvld janrtvld changed the title feat: added qr scanner package feat: QR scanner package May 22, 2023
Signed-off-by: Jan <jan@animo.id>
@janrtvld
Copy link
Contributor Author

Not sure what i can do about the CI, any ideas? @TimoGlastra

Jan and others added 2 commits May 22, 2023 17:10
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Member

Just pushed a fix

@TimoGlastra
Copy link
Member

I see you reverted the agent changes? I thought askar was fixed now right?

Jan added 3 commits May 22, 2023 18:07
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Jan <jan@animo.id>
@janrtvld
Copy link
Contributor Author

janrtvld commented May 22, 2023

I see you reverted the agent changes? I thought askar was fixed now right?

I was testing it with @blu3beri but there were still some issues.

@TimoGlastra
Copy link
Member

Then we need to revert some changes from my side i think

@TimoGlastra TimoGlastra merged commit e4a008b into main May 23, 2023
@TimoGlastra TimoGlastra deleted the feat/scanner branch May 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants