-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QR scanner package #1
Conversation
Signed-off-by: Jan <jan@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re the toasts, they're a bit hard to see on the white background, should we add some depth? I also see there's multiple ways to do toasts in the template. One using tamgui, the other using burnt (https://www.npmjs.com/package/burnt). Should we remove the burnt package? Or do we want to use some of it's features?
Co-authored-by: Timo Glastra <timo@animo.id>
I dont think we can remove burnt. It says that Toast relies on the burnt package https://tamagui.dev/docs/components/toast/1.15.15#toastprovider. |
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Jan <jan@animo.id>
Not sure what i can do about the CI, any ideas? @TimoGlastra |
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Just pushed a fix |
I see you reverted the agent changes? I thought askar was fixed now right? |
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Jan <jan@animo.id>
Signed-off-by: Jan <jan@animo.id>
I was testing it with @blu3beri but there were still some issues. |
Then we need to revert some changes from my side i think |
Note: Draft PR as i'm still working on the parsing for the QR scanner.This PR contains some general Tamagui setup and a QR scanner. The Tamagui components will probably still change in the future, but for now i created some base components. The
export * from 'tamagui'
has been removed and you should now only use predefined components from the'@internal/ui'
package.Current flow:
RPReplay_Final1684177142.MP4