fix presentation #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
force-pushed
the
fix-presentation
branch
from
6aa31e4 to
803f1fe
Compare
berendsliedrecht
force-pushed
the
fix-presentation
branch
2 times, most recently
from
1a2a23a to
9934d48
Compare
berendsliedrecht
force-pushed
the
fix-presentation
branch
from
9934d48 to
5a4fca2
Compare
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
berendsliedrecht
force-pushed
the
fix-presentation
branch
from
5a4fca2 to
6844e7b
Compare
Merged
TimoGlastra
reviewed
Aug 3, 2024
|
|
||
| setReceivedCredentials(await receiveOffer(receiveCredentialOfferUri)) | ||
| if (!receiveCredentialOfferOrPresentationUri) return | ||
| if (receiveCredentialOfferOrPresentationUri.startsWith('openid-credential-offer://')) { |
There was a problem hiding this comment.
I would not check based on the scheme, as we for paradym use https://paradym.id so we can use deep linking. And e.g. HAIP uses As a way to invoke the Wallet, at least a custom URL scheme haip:// MUST be supported.
So i think we should check whether credential_offer or credential_offer_uri params are present and extract those. That is the most robust method I think
There was a problem hiding this comment.
Can't open an issue for this as we're in a fork
TimoGlastra
approved these changes
Aug 3, 2024
TimoGlastra
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.