-
Notifications
You must be signed in to change notification settings - Fork 26
Raise error for showSelected2 aesthetic/parameter usage #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@tdhock there are multiple files such as where showSelected2,showSelected1 is used. I think it would be better to update. |
7d36a2a
to
ab8d33e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage ? 77.66%
=========================================
Files ? 164
Lines ? 8737
Branches ? 542
=========================================
Hits ? 6786
Misses ? 1951
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
when showSelected is a vector, it generates numbered columns (showSelected1, showSelected2) hence if I change other test file it gives error |
@tdhock can you please check |
closes #213
Adds a check for use of showSelected2 (and similar) in aesthetics or parameters, and raises an error matching the unit test:
"Use of clickSelects and showSelected as aesthetics has been deprecated. Please use as parameters."
Prevents silent user errors from typos like showSelected2.