Skip to content

Raise error for showSelected2 aesthetic/parameter usage #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

biplab-sutradhar
Copy link
Contributor

closes #213
Adds a check for use of showSelected2 (and similar) in aesthetics or parameters, and raises an error matching the unit test:
"Use of clickSelects and showSelected as aesthetics has been deprecated. Please use as parameters."

Prevents silent user errors from typos like showSelected2.

@biplab-sutradhar
Copy link
Contributor Author

biplab-sutradhar commented Aug 4, 2025

@tdhock there are multiple files such as
Climate-selected.R
test-compiler-plot-named-timexxx.R
test-compiler-save-separate-chunks.R
test-renderer1-geom-label-aligned.R
test-renderer1-WorldBank-NA.R

where showSelected2,showSelected1 is used. I think it would be better to update.

@biplab-sutradhar biplab-sutradhar force-pushed the fix-showSelected-aes-error branch from 7d36a2a to ab8d33e Compare August 10, 2025 00:22
Copy link

codecov bot commented Aug 10, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@d386bd2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/z_animintHelpers.R 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage          ?   77.66%           
=========================================
  Files             ?      164           
  Lines             ?     8737           
  Branches          ?      542           
=========================================
  Hits              ?     6786           
  Misses            ?     1951           
  Partials          ?        0           
Flag Coverage Δ
javascript 95.33% <ø> (?)
r 69.68% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@biplab-sutradhar
Copy link
Contributor Author

when showSelected is a vector, it generates numbered columns (showSelected1, showSelected2) hence if I change other test file it gives error

@biplab-sutradhar
Copy link
Contributor Author

@tdhock can you please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error message when user provides unrecognized geom parameter (e.g. showSelected2)
2 participants