Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled combobox data #232

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Controlled combobox data #232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b30921a
feat: add controllable state functionality to combobox items
hobbescodes Jan 29, 2024
2f6037e
chore: add note about possible early thrown error when using controll…
hobbescodes Jan 29, 2024
52f0156
Revert "feat: add controllable state functionality to combobox items"
coopbri Feb 1, 2024
d3c144b
fix(combobox): fix missing prop assertion logic
coopbri Feb 1, 2024
1a9c04c
fix(combobox): fix missing prop assertion logic
coopbri Feb 1, 2024
313ead9
feature(combobox,stories): add custom content story
coopbri Feb 1, 2024
49d4559
ci(changesets): add combobox changesets
coopbri Feb 1, 2024
9c410e4
Merge branch 'master' into feat/controlled-combobox
coopbri Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(combobox): fix missing prop assertion logic
  • Loading branch information
@coopbri
coopbri committed Feb 1, 2024
commit d3c144bc795febb6b9a6c57845486873557e1adb
11 changes: 4 additions & 7 deletions src/components/core/Combobox/Combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ export interface Props
};
/** Custom content render override. */
content?: ReactNode;
groups: Group[];
/** Groups of items to display. */
groups?: Group[];
itemIndicator?: boolean;
triggerEnabled?: boolean;
inputProps?: Omit<InputProps, "size">;
Expand All @@ -89,12 +90,8 @@ const Combobox = ({
const allItems = groups.flatMap((group) => group.items);
const [filteredItems, setFilteredItems] = useState(allItems);

// We could throw an error here like so (for descriptiive runtime error purposes):
// if (controlledItems && !setControlledItems) {
// throw new Error(
// "You must provide a `setControlledItems` callback when using `controlledItems`.",
// );
// }
if (!content || !groups)
throw new Error("Either the `content` or `groups` prop must be provided.");

const handleChange = (
evt: Parameters<
Expand Down