Update Toast component
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c31b456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Deploy preview for ui-storybook ready! ✅ Preview Built with commit c31b456. |
coopbri
reviewed
Jan 7, 2024
coopbri
reviewed
Jan 7, 2024
| export { default as toast } from "react-hot-toast"; | ||
| export type { ToastPosition } from "react-hot-toast"; | ||
| // export backfill of sonner functions | ||
| export { toast } from "sonner"; |
There was a problem hiding this comment.
Maybe export ToastT interface (potentially renaming because that's not a great name) here as well?
There was a problem hiding this comment.
Actually, I guess we're exporting implementation types. So nevermind about this my thoughts have changed!
coopbri
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task link: https://trello.com/c/cBg7CvcW/334-update-toast-to-use-sonner
Updated
Toastcomponent(s) to use sonner instead of react hot toast. Added primitives forToastbuilding blocks.Test Steps
react-hot-toastin codebase.