Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define layerStyles for ease of use downstream #202

Merged
merged 18 commits into from
Jan 3, 2024

Conversation

hobbescodes
Copy link
Contributor

@hobbescodes hobbescodes commented Jan 3, 2024

Description

Task link: https://trello.com/c/O45eOzvK/325-define-layerstyles-for-aniref-preset

Added layerStyles to ANIREF preset. This allows layerStyle prop for panda components to be accessible downstream and allows for quick default (or override) styling. Also updated the Button component recipe (added border width to base) to have consistent sizing across all variants. Updated Banner recipe to use custom gradientAccent layer style for defined gradient variant.

Test Steps

  1. Verify that styles look good for Button recipe updates (check hover states, disabled states, etc to make sure that they are consistent with what is expected).
  2. Verify that styles are rendered appropriately for Banner when gradient variant is used.
  3. Verify that layerStyle prop can be used and that the appropriate styles are applied.

Note

For third test step, apply layerStyle="subtleGradient" to any Flex container or whatever and verify that appropriate styles are rendered.

Warning

We may need to inspect downstream Buttons to verify that the added borderWidth in the recipes does not throw anything off in terms of layout and spacing. At the end of the day I believe that this change was appropriate so that each variant has consistent sizing.

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: ce22d2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@animareflection/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Deploy preview for ui-storybook ready!

✅ Preview
https://ui-storybook-hlyb01lmf-animareflection.vercel.app

Built with commit ce22d2f.
This pull request is being automatically deployed with vercel-action

@hobbescodes hobbescodes merged commit 5dcc96e into master Jan 3, 2024
@hobbescodes hobbescodes deleted the feat/define-layer-styles branch January 3, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants