-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define layerStyles
for ease of use downstream
#202
Conversation
🦋 Changeset detectedLatest commit: ce22d2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for ui-storybook ready! ✅ Preview Built with commit ce22d2f. |
Description
Task link: https://trello.com/c/O45eOzvK/325-define-layerstyles-for-aniref-preset
Added
layerStyles
to ANIREF preset. This allowslayerStyle
prop for panda components to be accessible downstream and allows for quick default (or override) styling. Also updated theButton
component recipe (added border width tobase
) to have consistent sizing across all variants. UpdatedBanner
recipe to use customgradientAccent
layer style for definedgradient
variant.Test Steps
Button
recipe updates (check hover states, disabled states, etc to make sure that they are consistent with what is expected).Banner
whengradient
variant is used.layerStyle
prop can be used and that the appropriate styles are applied.Note
For third test step, apply
layerStyle="subtleGradient"
to anyFlex
container or whatever and verify that appropriate styles are rendered.Warning
We may need to inspect downstream
Button
s to verify that the addedborderWidth
in the recipes does not throw anything off in terms of layout and spacing. At the end of the day I believe that this change was appropriate so that each variant has consistent sizing.