Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove heavy imports #110

Merged
merged 6 commits into from
Jul 29, 2021
Merged

remove heavy imports #110

merged 6 commits into from
Jul 29, 2021

Conversation

aniketmaurya
Copy link
Owner

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@aniketmaurya aniketmaurya added the enhancement New feature or request label Jul 29, 2021
@aniketmaurya aniketmaurya added this to the 0.1.1 milestone Jul 29, 2021
@aniketmaurya aniketmaurya self-assigned this Jul 29, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 29, 2021

Hello @aniketmaurya! Thanks for updating this PR.

Line 15:5: W503 line break before binary operator
Line 16:5: W503 line break before binary operator
Line 17:5: W503 line break before binary operator

Comment last updated at 2021-07-29 16:46:06 UTC

@github-actions github-actions bot added the test add/update tests label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #110 (fc81fbf) into master (cbd518e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   75.00%   75.03%   +0.03%     
==========================================
  Files          45       46       +1     
  Lines        1324     1326       +2     
==========================================
+ Hits          993      995       +2     
  Misses        331      331              
Flag Coverage Δ
unittests 75.03% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/utility/import_utils.py 100.00% <ø> (ø)
chitra/__init__.py 100.00% <100.00%> (ø)
chitra/image.py 78.57% <100.00%> (ø)
chitra/imports.py 100.00% <100.00%> (ø)
chitra/logging.py 66.66% <100.00%> (ø)
tests/serve/test_api.py 100.00% <100.00%> (ø)
tests/test_tf_image.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd518e...fc81fbf. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.2% 68.2% Coverage
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit 01c76cd into master Jul 29, 2021
@aniketmaurya aniketmaurya deleted the feature/remove_heavy_imports branch July 29, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants