Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 increase coverage #101

Merged
merged 4 commits into from
Jul 24, 2021

Conversation

sukkritsharmaofficial
Copy link
Contributor

@sukkritsharmaofficial sukkritsharmaofficial commented Jul 21, 2021

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@sukkritsharmaofficial sukkritsharmaofficial changed the title Test and fixers Test and fixes Jul 21, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @sukkritsharmaofficial! Thank you for opening your first pull request in this repo. We are so happy that you have decided to contribute and value your contribution. Please read these materials before proceeding: Contributing Guide and Code of Conduct.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #101 (42799a5) into master (95afe35) will decrease coverage by 0.18%.
The diff coverage is 41.66%.

❗ Current head 42799a5 differs from pull request most recent head 93629d0. Consider uploading reports for the commit 93629d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   73.39%   73.20%   -0.19%     
==========================================
  Files          44       44              
  Lines        1289     1321      +32     
==========================================
+ Hits          946      967      +21     
- Misses        343      354      +11     
Flag Coverage Δ
unittests 73.20% <41.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/serve/test_api.py 56.25% <27.77%> (-37.09%) ⬇️
chitra/converter/core.py 42.85% <50.00%> (+1.68%) ⬆️
chitra/datagenerator.py 47.58% <100.00%> (ø)
chitra/trainer.py 51.45% <100.00%> (+0.71%) ⬆️
chitra/__init__.py 100.00% <0.00%> (ø)
chitra/serve/app.py 93.61% <0.00%> (+3.14%) ⬆️
tests/serve/test_app.py 100.00% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95afe35...93629d0. Read the comment docs.

@aniketmaurya aniketmaurya self-requested a review July 21, 2021 16:47
@aniketmaurya aniketmaurya added the test add/update tests label Jul 21, 2021
@aniketmaurya aniketmaurya added this to the 0.1.0 milestone Jul 22, 2021
@aniketmaurya aniketmaurya changed the title Test and fixes 🚀 increase coverage Jul 22, 2021
@aniketmaurya
Copy link
Owner

@sukkritsharmaofficial can you merge this PR with master?

@aniketmaurya aniketmaurya merged commit 68a1612 into aniketmaurya:master Jul 24, 2021
Copy link
Owner

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants