Skip to content

Страница репозитория: Popover для клонирования#93

Merged
niyazm524 merged 7 commits intodevfrom
feature/clone-popover
Nov 22, 2020
Merged

Страница репозитория: Popover для клонирования#93
niyazm524 merged 7 commits intodevfrom
feature/clone-popover

Conversation

@niyazm524
Copy link
Collaborator

Closes: #80

@niyazm524 niyazm524 self-assigned this Nov 21, 2020
@niyazm524 niyazm524 requested a review from azinit November 21, 2020 17:07
@github-actions
Copy link

github-actions bot commented Nov 21, 2020

Visit the preview URL for this PR (updated for commit a633ad0):

(expires Sat, 12 Dec 2020 13:00:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@azinit
Copy link
Member

azinit commented Nov 21, 2020

Некритично, но подлиннее бы саму выпадашку сделал

(раза в 2, не обязательно чтоб flex-длина была, но побольше бы чутка)
image

UPD: В github самом - 350 (но там и шрифт меньше), и у нас - 237

image

@azinit
Copy link
Member

azinit commented Nov 21, 2020

image

Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сама выпадашка - огоньь, но по коду есть что улучшить)

azinit
azinit previously approved these changes Nov 21, 2020
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мисклик*

Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@niyazm524 niyazm524 merged commit 8bdce64 into dev Nov 22, 2020
@niyazm524 niyazm524 deleted the feature/clone-popover branch November 22, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Должен появляться popover для клонирования репы

2 participants