Skip to content

Доработки по авторизации, легкий рефакторинг#91

Merged
azinit merged 17 commits intodevfrom
feature/enhancements-1
Nov 22, 2020
Merged

Доработки по авторизации, легкий рефакторинг#91
azinit merged 17 commits intodevfrom
feature/enhancements-1

Conversation

@azinit
Copy link
Member

@azinit azinit commented Nov 20, 2020

CHANGELOG

image

@azinit azinit added this to the Спринт 2020_5 milestone Nov 20, 2020
@github-actions
Copy link

github-actions bot commented Nov 20, 2020

Visit the preview URL for this PR (updated for commit 68f8288):

(expires Sat, 12 Dec 2020 12:08:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@azinit azinit changed the title WIP: Доработки Доработки по авторизации, легкий рефакторинг Nov 21, 2020
Copy link
Member Author

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed

niyazm524
niyazm524 previously approved these changes Nov 22, 2020
Copy link
Collaborator

@niyazm524 niyazm524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

конфетка теперь (но иконка в навбаре всё-таки мыльная)

@niyazm524
Copy link
Collaborator

Почему кстати в навбаре не юзаются роутер линки?

@azinit
Copy link
Member Author

azinit commented Nov 22, 2020

Почему кстати в навбаре не юзаются роутер линки?

Надо тогда и хедер в роутер засовывать)

Проблема да, и до этого была замечена - но я пока посмотрел - вродь не так критично

image

@azinit
Copy link
Member Author

azinit commented Nov 22, 2020

конфетка теперь (но иконка в навбаре всё-таки мыльная)

Пофиксил

image

@azinit azinit requested a review from niyazm524 November 22, 2020 12:09
Copy link
Collaborator

@niyazm524 niyazm524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeee

@azinit azinit merged commit 52bdb3d into dev Nov 22, 2020
@azinit azinit deleted the feature/enhancements-1 branch November 22, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment