Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MassFlux Units combinations for kilograms, centimeter/millimeters, hours #784

Merged
merged 10 commits into from
May 13, 2020

Conversation

trb5016
Copy link
Contributor

@trb5016 trb5016 commented May 13, 2020

Add units to MassFlux quantity so that there are now:

  • g/s-m2
  • g/s-cm2
  • g/s-mm2
  • kg/s-m2
  • kg/s-cm2
  • kg/s-mm2
  • g/h-m2
  • g/h-cm2
  • g/h-mm2
  • kg/h-m2
  • kg/h-cm2
  • kg/h-mm2

@angularsen
Copy link
Owner

@tmilnthorp @lipchev Any chance one of you can review this? I'm super busy the next few days.

@codecov-io
Copy link

Codecov Report

Merging #784 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   63.79%   63.87%   +0.08%     
==========================================
  Files         279      279              
  Lines       41544    41644     +100     
==========================================
+ Hits        26501    26601     +100     
  Misses      15043    15043              
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100.00% <ø> (ø)
...ions/GeneratedCode/NumberToMassFluxExtensions.g.cs 100.00% <100.00%> (ø)
UnitsNet/GeneratedCode/Quantities/MassFlux.g.cs 58.68% <100.00%> (+10.29%) ⬆️
UnitsNet/GeneratedCode/UnitConverter.g.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c9f4c...f23dbf1. Read the comment docs.

Copy link
Collaborator

@lipchev lipchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the json- no remarks.
The calculations check out as well.

@angularsen
Copy link
Owner

angularsen commented May 13, 2020 via email

@lipchev
Copy link
Collaborator

lipchev commented May 13, 2020

@trb5016 It looks good- thank you. Just as a side note- I see that you are working on the same branch (trb5016:master) - this would eventually result in a rather long commit history. It is advisable, if possible, to delete your local branch after it has been merged. Alternatively there are ways to rebase onto master by just picking up some of the comments but I'm not exactly sure how this is supposed to be done...

@lipchev lipchev merged commit b20aef8 into angularsen:master May 13, 2020
@lipchev
Copy link
Collaborator

lipchev commented May 13, 2020

@angularsen I've created a draft release- please have a look, maybe it is because I didn't press the Publish release button, but the link to it still has this 'untagged' part that is worrying me a little (although I did create it 'From Tag' )

@angularsen
Copy link
Owner

@lipchev Can't access the link you gave, but I see the draft. It is perfectly safe for you to click publish, it looks good 👍

@lipchev
Copy link
Collaborator

lipchev commented May 13, 2020

UnitsNet/4.60.0 is out
PS The untagged part of the link now turned to tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants