-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MassFlux Units combinations for kilograms, centimeter/millimeters, hours #784
Conversation
@tmilnthorp @lipchev Any chance one of you can review this? I'm super busy the next few days. |
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 63.79% 63.87% +0.08%
==========================================
Files 279 279
Lines 41544 41644 +100
==========================================
+ Hits 26501 26601 +100
Misses 15043 15043
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the json- no remarks.
The calculations check out as well.
Great! If it is convenient, could you please merge and bump version to
release a new nuget too?
If not I can get around to that later.
|
@trb5016 It looks good- thank you. Just as a side note- I see that you are working on the same branch (trb5016:master) - this would eventually result in a rather long commit history. It is advisable, if possible, to delete your local branch after it has been merged. Alternatively there are ways to rebase onto master by just picking up some of the comments but I'm not exactly sure how this is supposed to be done... |
@angularsen I've created a draft release- please have a look, maybe it is because I didn't press the Publish release button, but the link to it still has this 'untagged' part that is worrying me a little (although I did create it 'From Tag' ) |
@lipchev Can't access the link you gave, but I see the draft. It is perfectly safe for you to click publish, it looks good 👍 |
UnitsNet/4.60.0 is out |
Add units to MassFlux quantity so that there are now: