Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NuGet packages to latest stable #727

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

sequc82
Copy link
Contributor

@sequc82 sequc82 commented Dec 10, 2019

Prerelease versions skipped. All available stable updates included

@angularsen
Copy link
Owner

Huh! Seems like som test coverage failed.
https://ci.appveyor.com/project/angularsen/unitsnet/builds/29444674#L328

I can take a look later if you don't figure it out.

@sequc82
Copy link
Contributor Author

sequc82 commented Dec 10, 2019

That was unusual. It seems there is an SDK that the test projects are referencing that held .NET Core from updating with the rest of the NuGet packages. An update to the .csproj files and restoration of NuGet packages seems to have resolved the issue.

@sequc82
Copy link
Contributor Author

sequc82 commented Dec 10, 2019

@angularsen Well it looks like the tests passed, but there seems to be an issue with codecov. Any ideas?

https://ci.appveyor.com/project/angularsen/unitsnet/builds/29447339

@codecov-io
Copy link

Codecov Report

Merging #727 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files         170      170           
  Lines       38375    38375           
=======================================
  Hits        22454    22454           
  Misses      15921    15921

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb54c3a...6067255. Read the comment docs.

@angularsen
Copy link
Owner

The codecov.io API seems to be a bit unstable, or perphaps the connection from the build agent. It doesn't happen very often, but sometimes it fails on this. I simply re-queued the build and it went through 😄

@angularsen angularsen merged commit 305ef08 into angularsen:master Dec 10, 2019
@angularsen
Copy link
Owner

Great stuff, thanks!

@sequc82 sequc82 deleted the Update-NuGet_pkgs branch December 10, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants