-
Notifications
You must be signed in to change notification settings - Fork 396
Add compressibility quantity #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
========================================
- Coverage 82.7% 82.6% -0.0%
========================================
Files 308 310 +2
Lines 47569 47922 +353
========================================
+ Hits 39293 39578 +285
- Misses 8276 8344 +68
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a minor typo, other than that you can go ahead and merge this
Are you sure it's plural pounds in InversePoundsForceInches? I see both forms used, but I seem to find more singular form than plural form. |
This is more associated with Pressure than Torque. That said, I'd love for @sveipa to clarify |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've run the singular vs plural case internally here without being able to conclude what's the right naming convention unfortunately. Sorry for not being able to help on this matter. |
If there is no clear cut convention, I vote we use singular form |
Can this PR be merged please? :-) |
I checked the code base and we have 40/60 mix of PoundForce vs PoundsForce, so I guess there is no consistency to begin with. Keeping it PoundsForce then. |
Sorry for the slow turnaround @sveipa @tmilnthorp , nuget is on the way out. |
Great, thanks @angularsen :-) |
Closes #1032