Skip to content

Conversation

@dafinoer
Copy link

migrate to null-safety for material toggle icon

@GZGavinZhao
Copy link

Hi, thanks for all of these patches! I'm currently fixing the CI. After it's done I'll enable it so that your code can run against the CI.

@GZGavinZhao GZGavinZhao self-requested a review October 22, 2022 22:40
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We migrate files starting from the bottom of the tree (i.e. first migrate files that don't depend on any other non-null-safe files). In this case, this file still depends on lib/model/ui/icon.dart, which is not null safe, so you have to migrate that file first (but it's small so this should be a quick fix :) )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for response, i will trying update the code for next commit for migrate icon.dart with null-safety.

@GZGavinZhao
Copy link

GZGavinZhao commented Oct 29, 2022

CI checks enabled. You can ignore the build errors for the beta SDK. Still fixing it on my end. Also, you may consider pulling in the latest commits from your fork so that the other jobs in the checks can pass.

@dafinoer dafinoer deleted the null-safety/button_decorator branch July 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants