Merge dev into null-safety

.gitignore

@@ -30,4 +30,7 @@ doc/api/
 # VsCode
 .vscode/
 !.vscode/settings.json
-.metals
+.metals
+
+testing/
+gen_app/

angular_components/CHANGELOG.md

@@ -3,7 +3,22 @@
 ## 2.0.0
 
 * Migrated using `dart migrate`
-* `Denomination` class throws ArguementError for incorrect suffix
+* Migrated `angular_gallery`
+* Migrated `angular_gallery_section`
+* Migrated `examples`
+* Replaced `pkg:mustache` with `pkg:mustache_template`
+* Changed `Denomination` class to throws ArgumentError for incorrect suffix
+* Removed deprecated `componentRenderer`
+* Changed parameters of method with `@ViewChild` annotation to be nullable
+* Changed parameters of component factory with `@Optional` annotation to be nullable
+* Changed parameters of component factory without `@Optional` annotation be non-nullable
+* Changed parameters of component constructor with `@Attribute` annotation to be nullable
+* Added `ChangeDetectionStrategy.OnPush` to `material_tree_dropdown`
+* Added `ChangeDetectionStrategy.OnPush` to `material_tree_filter`
+* Added `ChangeDetectionStrategy.OnPush` to `material_tree_impl`
+* Updated `disabled` to be non nullable
+* Replaced `DomSanitizationService` with `pkg:sanitizer_html`
+
 
 ## 1.0.3
 

angular_components/lib/angular_components.dart

@@ -228,7 +228,7 @@ const List<dynamic> materialDirectives = [
   DateRangeEditorComponent,
   DateRangeInputComponent,
   DeferredContentDirective,
-  displayNameRendererDirective,
+  DisplayNameRendererDirective,
   DropdownSelectValueAccessor,
   DropdownButtonComponent,
   DropdownMenuComponent,

angular_components/lib/app_layout/material_stackable_drawer.dart

@@ -23,7 +23,7 @@ import 'package:angular_components/content/deferred_content_aware.dart';
 )
 class MaterialStackableDrawerComponent
     extends MaterialTemporaryDrawerComponent {
-  final MaterialStackableDrawerComponent parent;
+  final MaterialStackableDrawerComponent? parent;
 
   MaterialStackableDrawerComponent(@Optional() @SkipSelf() this.parent)
       : super();
@@ -36,7 +36,7 @@ class MaterialStackableDrawerComponent
   set visible(bool newVisible) {
     super.visible = newVisible;
 
-    parent.isExpanded = newVisible;
+    parent?.isExpanded = newVisible;
   }
 
   @HostBinding('class.mat-drawer-collapsed')

angular_components/lib/button_decorator/button_decorator.dart

@@ -33,7 +33,7 @@ class ButtonDirective extends RootFocusable
 
   final _trigger = StreamController<UIEvent>.broadcast(sync: true);
 
-  String _hostTabIndex = '0';
+  String? _hostTabIndex = '0';
   final String? _nonTabbableIndex;
   bool _shouldHandleSpaceKey;
 
@@ -60,34 +60,35 @@ class ButtonDirective extends RootFocusable
   /// Is the component disabled.
   @HostBinding('class.is-disabled')
   @Input()
-  bool? disabled = false;
+  bool disabled = false;
 
   /// Is the component tabbable.
   @Input()
   bool tabbable = true;
 
-  String? get hostTabIndex =>
-      tabbable && !disabled! ? _hostTabIndex : _nonTabbableIndex;
+  String? get hostTabIndex {
+    return tabbable && !disabled ? _hostTabIndex : _nonTabbableIndex;
+  }
 
   /// The tab index of the component.
   ///
   /// The value is used if [tabbable] is `true` and [disabled] is `false`.
   @Input()
-  set tabindex(String value) {
+  set tabindex(String? value) {
     _hostTabIndex = value;
   }
 
   /// Triggers if not disabled.
   @HostListener('click')
   void handleClick(MouseEvent mouseEvent) {
-    if (disabled!) return;
+    if (disabled) return;
     _trigger.add(mouseEvent);
   }
 
   /// Triggers on enter and space if not disabled.
   @HostListener('keypress')
   void handleKeyPress(KeyboardEvent keyboardEvent) {
-    if (disabled!) return;
+    if (disabled) return;
     if (isSpaceKey(keyboardEvent) && !_shouldHandleSpaceKey) return;
     int keyCode = keyboardEvent.keyCode;
     if (keyCode == KeyCode.ENTER || isSpaceKey(keyboardEvent)) {

angular_components/lib/content/deferred_content.dart

@@ -23,9 +23,9 @@ class DeferredContentDirective implements OnDestroy {
   final _disposer = Disposer.oneShot();
   final _placeholder = DivElement();
 
-  ViewContainerRef? _viewContainer;
+  ViewContainerRef _viewContainer;
   EmbeddedViewRef? _viewRef;
-  TemplateRef? _template;
+  TemplateRef _template;
 
   /// Create a placeholder element to maintain content size when hidden.
   ///
@@ -59,7 +59,7 @@ class DeferredContentDirective implements OnDestroy {
         // Remove the placeholder and add the deferred content.
         _placeholder.remove();
       }
-      _viewRef = _viewContainer!.createEmbeddedView(_template!);
+      _viewRef = _viewContainer.createEmbeddedView(_template);
     } else {
       if (preserveDimensions) {
         // Save the dimensions of the deferred content.
@@ -76,11 +76,11 @@ class DeferredContentDirective implements OnDestroy {
       }
 
       // Remove the deferred content.
-      _viewContainer!.clear();
+      _viewContainer.clear();
 
       if (preserveDimensions) {
         // Add the placeholder so the parent's size doesn't change.
-        var container = _viewContainer!.element.nativeElement;
+        var container = _viewContainer.element.nativeElement;
         if (container?.parentNode != null) {
           container.parentNode.insertBefore(_placeholder, container);
         }
@@ -105,8 +105,8 @@ class DeferredContentDirective implements OnDestroy {
   @override
   void ngOnDestroy() {
     _disposer.dispose();
-    _viewContainer = null;
-    _template = null;
+    //_viewContainer = null;
+    //_template = null;
   }
 }
 
@@ -120,8 +120,8 @@ class DeferredContentDirective implements OnDestroy {
   selector: '[cachedDeferredContent]',
 )
 class CachingDeferredContentDirective implements OnDestroy {
-  ViewContainerRef? _viewContainer;
-  TemplateRef? _template;
+  ViewContainerRef _viewContainer;
+  TemplateRef _template;
   final _disposer = Disposer.oneShot();
   ViewRef? _view;
 
@@ -131,7 +131,7 @@ class CachingDeferredContentDirective implements OnDestroy {
   void _setVisible(bool value) {
     if (value == _visible) return;
     if (value && _view == null) {
-      _view = _viewContainer!.createEmbeddedView(_template!);
+      _view = _viewContainer.createEmbeddedView(_template);
     }
     _visible = value;
   }
@@ -151,7 +151,7 @@ class CachingDeferredContentDirective implements OnDestroy {
   @override
   void ngOnDestroy() {
     _disposer.dispose();
-    _viewContainer = null;
-    _template = null;
+    //_viewContainer = null;
+    //_template = null;
   }
 }

angular_components/lib/dynamic_component/dynamic_component.dart

@@ -25,7 +25,7 @@ class DynamicComponent implements OnDestroy, AfterChanges {
   bool _loadDeferred = false;
 
   @ViewChild('marker', read: ViewContainerRef)
-  set viewContainerRef(ViewContainerRef value) {
+  set viewContainerRef(ViewContainerRef? value) {
     _viewContainerRef = value;
     if (_loadDeferred) {
       _initialize();
@@ -65,14 +65,14 @@ class DynamicComponent implements OnDestroy, AfterChanges {
   /// The type of component to dynamically render.
   @Deprecated('Use componentFactory instead as it is more tree-shakable')
   @Input()
-  set componentType(Type dartType) {
+  set componentType(Type? dartType) {
     if (_componentType != dartType) _typeChanged = true;
     _componentType = dartType;
   }
 
   /// The component factory of the component to dynamically render.
   @Input()
-  set componentFactory(ComponentFactory component) {
+  set componentFactory(ComponentFactory? component) {
     if (_componentFactory != component) _factoryChanged = true;
     _componentFactory = component;
   }
@@ -112,25 +112,25 @@ class DynamicComponent implements OnDestroy, AfterChanges {
           _componentFactory!, _viewContainerRef!);
       _onLoadController.add(_childComponent);
       _updateChildComponent();
-    // } else if (_componentType != null) {
-    //   // TODO(google): Remove this code once componentType is no longer used.
-    //   Type loadType = _componentType;
-    //   _slowComponentLoader
-    //       .loadNextToLocation(loadType, _viewContainerRef)
-    //       .then((ComponentRef componentRef) {
-    //     if (loadType != _componentType) {
-    //       // During the load time, the component type has changed,
-    //       // and the type we just loaded is no longer valid.
-    //       componentRef.destroy();
-    //       return;
-    //     }
-    //     if (_childComponent != null) {
-    //       throw 'Attempting to overwrite a dynamic component';
-    //     }
-    //     _childComponent = componentRef;
-    //     _onLoadController.add(componentRef);
-    //     _updateChildComponent();
-    //   });
+      // } else if (_componentType != null) {
+      //   // TODO(google): Remove this code once componentType is no longer used.
+      //   Type loadType = _componentType;
+      //   _slowComponentLoader
+      //       .loadNextToLocation(loadType, _viewContainerRef)
+      //       .then((ComponentRef componentRef) {
+      //     if (loadType != _componentType) {
+      //       // During the load time, the component type has changed,
+      //       // and the type we just loaded is no longer valid.
+      //       componentRef.destroy();
+      //       return;
+      //     }
+      //     if (_childComponent != null) {
+      //       throw 'Attempting to overwrite a dynamic component';
+      //     }
+      //     _childComponent = componentRef;
+      //     _onLoadController.add(componentRef);
+      //     _updateChildComponent();
+      //   });
     }
   }
 

angular_components/lib/focus/focus.dart

@@ -194,7 +194,7 @@ class AutoFocusDirective extends RootFocusable implements OnInit, OnDestroy {
   // These fields are not final to support nulling them out for easier memory
   // leak detection.
   Focusable? _focusable;
-  DomService? _domService;
+  DomService _domService;
   ModalComponent? _modal;
   PopupRef? _popupRef;
 
@@ -222,7 +222,7 @@ class AutoFocusDirective extends RootFocusable implements OnInit, OnDestroy {
       _disposer.addStreamSubscription(
           onVisibleChanged.listen(_onModalOrPopupVisibleChanged));
     } else {
-      _domService!.scheduleWrite(focus);
+      _domService.scheduleWrite(focus);
     }
   }
 
@@ -231,8 +231,8 @@ class AutoFocusDirective extends RootFocusable implements OnInit, OnDestroy {
   /// This value should not change during the component's life.
   // TODO(google): Change to an attribute.
   @Input()
-  set autoFocus(bool value) {
-    _autoFocus = value;
+  set autoFocus(bool? value) {
+    _autoFocus = value ?? false;
   }
 
   @override
@@ -251,13 +251,13 @@ class AutoFocusDirective extends RootFocusable implements OnInit, OnDestroy {
     super.dispose();
     _disposer.dispose();
     _focusable = null;
-    _domService = null;
+    //_domService = null;
     _modal = null;
     _popupRef = null;
   }
 
   void _onModalOrPopupVisibleChanged(bool isVisible) {
-    if (isVisible) _domService!.scheduleWrite(focus);
+    if (isVisible) _domService.scheduleWrite(focus);
   }
 }
 

angular_components/lib/focus/focus_list.dart

@@ -30,16 +30,21 @@ class FocusListDirective implements OnDestroy {
 
   @HostBinding('attr.role')
   final String role;
+
   @HostBinding('attr.ignoreUpAndDown')
-  final bool ignoreUpAndDown;
+  String get ignoreUpAndDownStr => '$ignoreUpAndDown';
+
+  bool ignoreUpAndDown = false;
+
   final _disposer = Disposer.multi();
   final _children = <FocusableItem>[];
   int get _length => _children.length;
 
   FocusListDirective(this._ngZone, @Attribute('role') String? role,
-      @Attribute('ignoreUpAndDown') String ignoreUpAndDown)
+      @Attribute('ignoreUpAndDown') String? ignoreUpAndDown)
       : this.role = role ?? 'list',
-        this.ignoreUpAndDown = attributeToBool(ignoreUpAndDown);
+        this.ignoreUpAndDown =
+            attributeToBool(ignoreUpAndDown, defaultValue: false);
 
   /// Whether focus movement loops from the end of the list to the beginning of
   /// the list. Default is `false`.

angular_components/lib/focus/focus_trap.dart

@@ -24,13 +24,13 @@ class FocusTrapComponent implements OnDestroy {
 
   AutoFocusDirective? _autoFocusDirective;
   @ContentChild(AutoFocusDirective)
-  set autoFocus(AutoFocusDirective value) {
+  set autoFocus(AutoFocusDirective? value) {
     _autoFocusDirective = value;
   }
 
   FocusContentWrapper? _content;
   @ViewChild(FocusContentWrapper)
-  set content(FocusContentWrapper value) {
+  set content(FocusContentWrapper? value) {
     _content = value;
     if (_content != null && _autoFocusDirective == null) {
       _content!._element.focus();
@@ -43,19 +43,21 @@ class FocusTrapComponent implements OnDestroy {
   }
 
   void focusFirst() {
-    _focusFirstInOrder(
-        DomTreeIterator(_content!.element, scope: _content!.element));
+    if (_content != null) {
+      _focusFirstInOrder(
+          DomTreeIterator(_content!.element, scope: _content!.element));
+    }
   }
 
   void focusLast() {
     _focusFirstInOrder(DomTreeIterator(_content!.element,
         scope: _content!.element, reverse: true, wraps: true));
   }
 
-  void _focusFirstInOrder(Iterator<Element?> iterator) {
+  void _focusFirstInOrder(Iterator<Element> iterator) {
     while (iterator.moveNext()) {
-      if (iterator.current!.tabIndex == 0 && _visible(iterator.current!)) {
-        iterator.current!.focus();
+      if (iterator.current.tabIndex == 0 && _visible(iterator.current)) {
+        iterator.current.focus();
         return;
       }
     }

angular_components/lib/interfaces/has_disabled.dart

@@ -4,5 +4,5 @@
 
 /// Interface for classes accepting a disabled setting.
 abstract class HasDisabled {
-  bool? disabled;
+  bool disabled = false;
 }