Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ngdart)!: rename and remove deprecated fields from ChangeDetectionStrategy #41

Merged

Conversation

ykmnkmi
Copy link

@ykmnkmi ykmnkmi commented Mar 7, 2023

No description provided.

@ykmnkmi ykmnkmi changed the title [ngdart] more static analysis warnings refactor(ngdart)!: rename and remove deprecated strategies from ChangeDetectionStrategy Mar 7, 2023
@GZGavinZhao GZGavinZhao self-requested a review March 8, 2023 03:07
@ykmnkmi ykmnkmi changed the title refactor(ngdart)!: rename and remove deprecated strategies from ChangeDetectionStrategy refactor(ngdart)!: rename and remove deprecated fields from ChangeDetectionStrategy and ViewEncapsulation Mar 9, 2023
@GZGavinZhao
Copy link

You may want to submit the enum migrations one by one if doing it all together is too much.

@ykmnkmi
Copy link
Author

ykmnkmi commented Mar 10, 2023

Do you mean ViewEncapsulation?

@GZGavinZhao
Copy link

Yes.

@ykmnkmi ykmnkmi changed the title refactor(ngdart)!: rename and remove deprecated fields from ChangeDetectionStrategy and ViewEncapsulation refactor(ngdart)!: rename and remove deprecated fields from ChangeDetectionStrategy Mar 14, 2023
@ykmnkmi ykmnkmi marked this pull request as ready for review March 15, 2023 04:19
Copy link

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@GZGavinZhao GZGavinZhao merged commit 3c5523a into angulardart-community:master Mar 16, 2023
@ykmnkmi ykmnkmi deleted the static_analysis_public branch March 17, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants