This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(timer): setInterval should not auto cancel after callback invoked, fix rxjs version to pass CI #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #934.
setInterval
will auto clear timerId after first time invoked.the issue was imported several versions ago, but it doesn't become a problem because we
return
ZoneTask
fromsetInterval
beforezone.js 0.8.17
, fromzone.js 0.8.18
,setInterval
will return the originaltimerId
, so when we callclearInterval
thetimerId
have been cleared, which will cause zone.jsonHasTask
not be called, thesetInterval
task was always there.And will cause
ngZone
not stable.Also fix
rxjs
version to5.4.2
to avoidkaram
error, I will continue to figure out how to resolvekaram
test error withrxjs 5.5.0
.The issue is here, and it seems it will be fixed in
rxjs 5.5.1
ReactiveX/rxjs#2971